r/devops • • 7h ago

Discussion Why are we still reviewing massive PRs in alphabetical file order?

16 Upvotes

I was looking into ways to improve how teams review pull requests now that engineers are using agents to generate large multi-file changes. But I noticed an issue with how fast mental models break down when reading a standard diff. 

When an agent puts together a 20-file change, git diff lists those files alphabetically. You end up reading utility helpers or UI components before you even reach the underlying database schema or core interfaces that dictate how they behave. You would spend half the review reconstructing the call graph in your head instead of evaluating the actual logic. 

Dependency-aware reading orders (grouping files by architectural hierarchy rather than folder names) is like the correct thing to do, and it made me wonder why review interfaces still treat diffs like flat alphabetical lists.

How do you read a 20-file diff? Do you have a specific order you follow?


r/devops • • 7h ago

Ops / Incidents Title: What does your deployment actually verify?

0 Upvotes

Disclosure: I work on the platform this happened on. No links and nothing to sell, I just don't have a good answer to the question.

We deployed an app last week, and every signal said it had worked. The deploy was marked as running, the health check was green, and every tool in the pipeline reported success.

Except the app was incomplete. Eight of its 27 starter records had never been created. The API rejected them one by one with permission errors while accepting the records around them.

The setup step actually caught this. It printed a warning saying the app was incomplete and shouldn't be treated as a successful deployment. Then it exited with code zero, so everything downstream happily marked the deploy as successful.

We had a health check proving the process was alive, but nothing proving that the application matched what we thought we had deployed.

I have been trying to work out what the right check should be, and none of the obvious answers feels complete.

A health endpoint returning 200 only tells you the process is running and the port is open. It says nothing about whether the expected data or configuration exists.

A smoke test against a few routes is better, but it only covers whatever somebody remembered to include. In this case, the missing records weren't part of that test.

Comparing the declared state with the actual state feels like the right answer. But that requires the deployment to produce a manifest of everything it intended to create, and most deployment systems don't seem to do that.

You could also fail on every warning, but then harmless warnings become blockers, people add skip flags, and eventually you are back where you started.

The two cases I am still stuck on are partial failures, where each individual rejection might be valid but the overall pattern is clearly wrong, and tools that print serious warnings but still exit zero. That convention isn't going away anytime soon.

And before anyone says readiness probes: readiness tells you whether the application can serve traffic. It doesn’t tell you whether it's the application you intended to deploy.

What does your deployment actually verify beyond "the process is running"? And what has shipped half-finished before you noticed?


r/devops • • 9h ago

Discussion How to manage access for 50 EKS cluster with AWS IAM?

0 Upvotes

When you have 50 EKS clusters, how do you manage and configure which developers have access to specific clusters using RBAC and AWS IAM? Isn’t it too much to manually configure IAM with k8 mappings on every single cluster?


r/devops • • 21h ago

Discussion GitHub is making CI/CD workflows more predictable with workflow dependency lockfiles…

0 Upvotes

…but securing your pipeline is only half the battle.
What happens between a successful build and production?

Who reviewed the changes? Who approved the release? Can you trace exactly what shipped? And if something breaks, can you roll back quickly?

As teams adopt AI coding agents and ship code faster, controlling the release process becomes just as important as writing the code itself.


r/devops • • 31m ago

Discussion For those of you who use open-spec, what's your method for tracking work alongside proposed changes to the spec?

• Upvotes

I've been trying to determine a pattern where proposed changes get made to the open-spec config, and a PR is reviewed, approved, and merged with those proposed changes. At that point then, team-members can address those proposed features. But it's a little cumbersome. Just looking for the most elegant way to do this if that's possible.